From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hangbin Liu Subject: Re: [PATCH iproute2-next] geneve: fix ttl inherit behavior Date: Fri, 28 Sep 2018 08:59:36 +0800 Message-ID: <20180928005936.GE24677@leo.usersys.redhat.com> References: <1538033257-32244-1-git-send-email-liuhangbin@gmail.com> <20180927090835.GU14666@orbyte.nwl.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: Phil Sutter , netdev@vger.kernel.org, Stephen Hemminger , David Ahern Return-path: Received: from mail-pf1-f193.google.com ([209.85.210.193]:41613 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726081AbeI1HUv (ORCPT ); Fri, 28 Sep 2018 03:20:51 -0400 Received: by mail-pf1-f193.google.com with SMTP id m77-v6so3064039pfi.8 for ; Thu, 27 Sep 2018 17:59:48 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180927090835.GU14666@orbyte.nwl.cc> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Sep 27, 2018 at 11:08:36AM +0200, Phil Sutter wrote: > On Thu, Sep 27, 2018 at 03:27:37PM +0800, Hangbin Liu wrote: > > Currently when we add geneve with "ttl inherit", we set ttl to 0, which > > is actually use whatever default value instead of inherit the inner > > protocol's ttl value. > > > > To respect compatibility with old behavior and make a difference between > > ttl inherit and ttl == 0, we add an attribute IFLA_GENEVE_TTL_INHERIT in > > kernel commit 52d0d404d39dd ("geneve: add ttl inherit support"). > > > > Now let's use "ttl inherit" to inherit the inner protocol's ttl, and use > > "ttl auto" to means "use whatever default value", the same behavior with > > ttl == 0. > > > > Reported-by: Jianlin Shi > > Signed-off-by: Hangbin Liu > > Acked-by: Phil Sutter Hi Stephen, David, Please hold on this path and let me fix the inherit flag issue first. Thanks Hangbin