From mboxrd@z Thu Jan 1 00:00:00 1970 From: Phil Sutter Subject: Re: [PATCH net] vxlan: use nla_put_flag for ttl inherit Date: Fri, 28 Sep 2018 12:37:00 +0200 Message-ID: <20180928103700.GC14666@orbyte.nwl.cc> References: <1538096906-20866-1-git-send-email-liuhangbin@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, David Miller , Stephen Hemminger , David Ahern To: Hangbin Liu Return-path: Received: from orbyte.nwl.cc ([151.80.46.58]:54492 "EHLO orbyte.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729228AbeI1RAL (ORCPT ); Fri, 28 Sep 2018 13:00:11 -0400 Content-Disposition: inline In-Reply-To: <1538096906-20866-1-git-send-email-liuhangbin@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Sep 28, 2018 at 09:08:26AM +0800, Hangbin Liu wrote: > Phil pointed out that there is a mismatch between vxlan and geneve ttl inherit. > We should define it as a flag and use nla_put_flag to export this opiton. s/opiton/option/ Apart from that, LGTM! Thanks, Phil