From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hangbin Liu Subject: Re: [PATCH net] vxlan: use nla_put_flag for ttl inherit Date: Fri, 28 Sep 2018 20:38:58 +0800 Message-ID: <20180928123858.GF24677@leo.usersys.redhat.com> References: <1538096906-20866-1-git-send-email-liuhangbin@gmail.com> <20180928103700.GC14666@orbyte.nwl.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Phil Sutter , netdev@vger.kernel.org, Stephen Hemminger , David Ahern To: David Miller Return-path: Received: from mail-pg1-f194.google.com ([209.85.215.194]:41007 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726345AbeI1TCp (ORCPT ); Fri, 28 Sep 2018 15:02:45 -0400 Received: by mail-pg1-f194.google.com with SMTP id z3-v6so4389102pgv.8 for ; Fri, 28 Sep 2018 05:39:10 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20180928103700.GC14666@orbyte.nwl.cc> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Sep 28, 2018 at 12:37:00PM +0200, Phil Sutter wrote: > On Fri, Sep 28, 2018 at 09:08:26AM +0800, Hangbin Liu wrote: > > Phil pointed out that there is a mismatch between vxlan and geneve ttl inherit. > > We should define it as a flag and use nla_put_flag to export this opiton. > > s/opiton/option/ > > Apart from that, LGTM! > > Thanks, Phil Opps, sorry... Hi David, Should I re-send a patch or will you help fix it directly? Thanks Hangbin