Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ycheng@google.com
Cc: edumazet@google.com, netdev@vger.kernel.org,
	ncardwell@google.com, weiwan@google.com, soheil@google.com
Subject: Re: [PATCH net-next v2] tcp: up initial rmem to 128KB and SYN rwin to around 64KB
Date: Sat, 29 Sep 2018 11:23:14 -0700 (PDT)	[thread overview]
Message-ID: <20180929.112314.687721909787322730.davem@davemloft.net> (raw)
In-Reply-To: <20180928200902.62121-1-ycheng@google.com>

From: Yuchung Cheng <ycheng@google.com>
Date: Fri, 28 Sep 2018 13:09:02 -0700

> Previously TCP initial receive buffer is ~87KB by default and
> the initial receive window is ~29KB (20 MSS). This patch changes
> the two numbers to 128KB and ~64KB (rounding down to the multiples
> of MSS) respectively. The patch also simplifies the calculations s.t.
> the two numbers are directly controlled by sysctl tcp_rmem[1]:
> 
>   1) Initial receiver buffer budget (sk_rcvbuf): while this should
>      be configured via sysctl tcp_rmem[1], previously tcp_fixup_rcvbuf()
>      always override and set a larger size when a new connection
>      establishes.
> 
>   2) Initial receive window in SYN: previously it is set to 20
>      packets if MSS <= 1460. The number 20 was based on the initial
>      congestion window of 10: the receiver needs twice amount to
>      avoid being limited by the receive window upon out-of-order
>      delivery in the first window burst. But since this only
>      applies if the receiving MSS <= 1460, connection using large MTU
>      (e.g. to utilize receiver zero-copy) may be limited by the
>      receive window.
> 
> This patch also lowers the initial bytes expected to receive in
> the receiver buffer autotuning algorithm - otherwise the receiver
> may take two to three rounds to increase the buffer to the
> appropriate level (2x sender congestion window).
> 
> With this patch TCP memory configuration is more straight-forward and
> more properly sized to modern high-speed networks by default. Several
> popular stacks have been announcing 64KB rwin in SYNs as well.
> 
> Signed-off-by: Yuchung Cheng <ycheng@google.com>
> Signed-off-by: Wei Wang <weiwan@google.com>
> Signed-off-by: Neal Cardwell <ncardwell@google.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reviewed-by: Soheil Hassas Yeganeh <soheil@google.com>

Applied, thanks.

  reply	other threads:[~2018-09-30  0:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-28 20:09 [PATCH net-next v2] tcp: up initial rmem to 128KB and SYN rwin to around 64KB Yuchung Cheng
2018-09-29 18:23 ` David Miller [this message]
2018-10-01 22:18   ` Yuchung Cheng
2018-10-01 22:20     ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180929.112314.687721909787322730.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=ncardwell@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=soheil@google.com \
    --cc=weiwan@google.com \
    --cc=ycheng@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox