From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hangbin Liu Subject: Re: [PATCH net] vxlan: use nla_put_flag for ttl inherit Date: Sat, 29 Sep 2018 17:01:03 +0800 Message-ID: <20180929090103.GG24677@leo.usersys.redhat.com> References: <1538096906-20866-1-git-send-email-liuhangbin@gmail.com> <20180928103700.GC14666@orbyte.nwl.cc> <20180928123858.GF24677@leo.usersys.redhat.com> <9b444c06-d3d3-1bbe-1edd-e2fe7ec1932b@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Miller , Phil Sutter , netdev@vger.kernel.org, Stephen Hemminger To: David Ahern Return-path: Received: from mail-pg1-f195.google.com ([209.85.215.195]:40575 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727674AbeI2P2x (ORCPT ); Sat, 29 Sep 2018 11:28:53 -0400 Received: by mail-pg1-f195.google.com with SMTP id n31-v6so6100884pgm.7 for ; Sat, 29 Sep 2018 02:01:14 -0700 (PDT) Content-Disposition: inline In-Reply-To: <9b444c06-d3d3-1bbe-1edd-e2fe7ec1932b@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Sep 28, 2018 at 11:56:10AM -0600, David Ahern wrote: > On 9/28/18 6:38 AM, Hangbin Liu wrote: > > On Fri, Sep 28, 2018 at 12:37:00PM +0200, Phil Sutter wrote: > >> On Fri, Sep 28, 2018 at 09:08:26AM +0800, Hangbin Liu wrote: > >>> Phil pointed out that there is a mismatch between vxlan and geneve ttl inherit. > >>> We should define it as a flag and use nla_put_flag to export this opiton. > >> > >> s/opiton/option/ > >> > >> Apart from that, LGTM! > >> > >> Thanks, Phil > > > > Opps, sorry... > > > > Hi David, > > > > Should I re-send a patch or will you help fix it directly? > > > > Thanks > > Hangbin > > > > you have this targeted at net; is it a bug in current iproute2 or an > update to a new feature in -next? Hi David Ahern, This patch targets to kernel net tree. The previous question is for "David Miller". Sorry for the confusing. Anyway, I will send a v2 patch for this one as I need to change the commit message. Thanks Hangbin