From: Stephen Hemminger <stephen@networkplumber.org>
To: netdev@vger.kernel.org
Cc: Stephen Hemminger <sthemmin@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH] hv_netvsc: remove ndo_poll_controller
Date: Sat, 29 Sep 2018 14:54:25 +0200 [thread overview]
Message-ID: <20180929145425.08f5a2e6@shemminger-XPS-13-9360> (raw)
In-Reply-To: <20180929125256.25994-1-sthemmin@microsoft.com>
On Sat, 29 Sep 2018 14:52:56 +0200
Stephen Hemminger <stephen@networkplumber.org> wrote:
> Similar to other patches from ERic.
>
> As diagnosed by Song Liu, ndo_poll_controller() can
> be very dangerous on loaded hosts, since the cpu
> calling ndo_poll_controller() might steal all NAPI
> contexts (for all RX/TX queues of the NIC). This capture
> can last for unlimited amount of time, since one
> cpu is generally not able to drain all the queues under load.
>
> In netvsc driver it uses NAPI for TX completions. The default
> poll_napi will do this for us now and avoid the capture.
>
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>
> Cc: Eric Dumazet <edumazet@google.com>
Forgot to label this, it is for net-next.
next prev parent reply other threads:[~2018-09-29 19:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-29 12:52 [PATCH] hv_netvsc: remove ndo_poll_controller Stephen Hemminger
2018-09-29 12:54 ` Stephen Hemminger [this message]
2018-09-29 14:12 ` Haiyang Zhang
2018-10-03 5:57 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180929145425.08f5a2e6@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=edumazet@google.com \
--cc=haiyangz@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox