From: David Ahern <dsahern@kernel.org>
To: netdev@vger.kernel.org
Cc: stephen@networkplumber.org, christian@brauner.io,
David Ahern <dsahern@gmail.com>
Subject: [PATCH iproute2-next 00/11] Fix dump requests to use proper header for type
Date: Sat, 29 Sep 2018 10:59:20 -0700 [thread overview]
Message-ID: <20180929175931.18448-1-dsahern@kernel.org> (raw)
From: David Ahern <dsahern@gmail.com>
iproute2 currently uses ifinfomsg as the header for all dumps using the
wilddump headers. This is wrong as each message type actually has its own
header type. While the kernel has traditionally let it go as it for the
most part only uses the family entry, the use of kernel side filters is
increasing to alter what is returned on a request. The kernel side filters
really need to use the proper header type.
To that end, fix iproute2 to use the proper header struct for the GET type.
David Ahern (11):
libnetlink: Convert GETADDR dumps to use rtnl_addrdump_req
libnetlink: Convert GETROUTE dumps to use rtnl_routedump_req
libnetlink: Convert GETADDRLABEL dumps to use rtnl_addrlbldump_req
libnetlink: Convert GETMDB dumps to use rtnl_mdbdump_req
libnetlink: Convert GETNETCONF dumps to use rtnl_netconfdump_req
libnetlink: Convert GETRULE dumps to use rtnl_ruledump_req
libnetlink: Convert GETNEIGH dumps to use rtnl_neighdump_req
libnetlink: Convert GETNEIGHTBL dumps to use rtnl_neightbldump_req
libnetlink: Convert GETNSID dumps to use rtnl_nsiddump_req
libnetlink: Rename rtnl_wilddump_* to rtnl_linkdump_*
libnetlink: Rename rtnl_wilddump_stats_req_filter to
rtnl_statsdump_req_filter
bridge/link.c | 4 +-
bridge/mdb.c | 2 +-
bridge/vlan.c | 10 +---
include/libnetlink.h | 30 ++++++++--
ip/ipaddress.c | 10 ++--
ip/ipaddrlabel.c | 4 +-
ip/iplink.c | 4 +-
ip/iplink_xstats.c | 4 +-
ip/ipmroute.c | 2 +-
ip/ipnetconf.c | 3 +-
ip/ipnetns.c | 2 +-
ip/ipntable.c | 2 +-
ip/iproute.c | 4 +-
ip/iprule.c | 2 +-
ip/iptoken.c | 2 +-
ip/iptuntap.c | 2 +-
ip/rtmon.c | 2 +-
ip/tunnel.c | 2 +-
lib/libnetlink.c | 164 ++++++++++++++++++++++++++++++++++++++++++++++++---
lib/ll_map.c | 2 +-
misc/arpd.c | 2 +-
misc/ifstat.c | 6 +-
22 files changed, 210 insertions(+), 55 deletions(-)
--
2.11.0
next reply other threads:[~2018-09-30 0:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-29 17:59 David Ahern [this message]
2018-09-29 17:59 ` [PATCH iproute2-next 01/11] libnetlink: Convert GETADDR dumps to use rtnl_addrdump_req David Ahern
2018-09-30 9:35 ` Stephen Hemminger
2018-09-30 15:37 ` David Ahern
2018-09-29 17:59 ` [PATCH iproute2-next 02/11] libnetlink: Convert GETROUTE dumps to use rtnl_routedump_req David Ahern
2018-09-29 17:59 ` [PATCH iproute2-next 03/11] libnetlink: Convert GETADDRLABEL dumps to use rtnl_addrlbldump_req David Ahern
2018-09-29 17:59 ` [PATCH iproute2-next 04/11] libnetlink: Convert GETMDB dumps to use rtnl_mdbdump_req David Ahern
2018-09-29 17:59 ` [PATCH iproute2-next 05/11] libnetlink: Convert GETNETCONF dumps to use rtnl_netconfdump_req David Ahern
2018-09-29 17:59 ` [PATCH iproute2-next 06/11] libnetlink: Convert GETRULE dumps to use rtnl_ruledump_req David Ahern
2018-09-29 17:59 ` [PATCH iproute2-next 07/11] libnetlink: Convert GETNEIGH dumps to use rtnl_neighdump_req David Ahern
2018-09-29 17:59 ` [PATCH iproute2-next 08/11] libnetlink: Convert GETNEIGHTBL dumps to use rtnl_neightbldump_req David Ahern
2018-09-29 17:59 ` [PATCH iproute2-next 09/11] libnetlink: Convert GETNSID dumps to use rtnl_nsiddump_req David Ahern
2018-09-29 17:59 ` [PATCH iproute2-next 10/11] libnetlink: Rename rtnl_wilddump_* to rtnl_linkdump_* David Ahern
2018-09-29 17:59 ` [PATCH iproute2-next 11/11] libnetlink: Rename rtnl_wilddump_stats_req_filter to rtnl_statsdump_req_filter David Ahern
2018-09-30 18:45 ` [PATCH iproute2-next 00/11] Fix dump requests to use proper header for type Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180929175931.18448-1-dsahern@kernel.org \
--to=dsahern@kernel.org \
--cc=christian@brauner.io \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).