From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2-next 01/11] libnetlink: Convert GETADDR dumps
 to use rtnl_addrdump_req
Date: Sun, 30 Sep 2018 11:35:41 +0200
Message-ID: <20180930113541.4bf9113d@shemminger-XPS-13-9360>
References: <20180929175931.18448-1-dsahern@kernel.org>
        <20180929175931.18448-2-dsahern@kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: netdev@vger.kernel.org, christian@brauner.io,
        David Ahern <dsahern@gmail.com>
To: David Ahern <dsahern@kernel.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-wr1-f68.google.com ([209.85.221.68]:41280 "EHLO
        mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727755AbeI3QIF (ORCPT
        <rfc822;netdev@vger.kernel.org>); Sun, 30 Sep 2018 12:08:05 -0400
Received: by mail-wr1-f68.google.com with SMTP id j15-v6so10583473wrt.8
        for <netdev@vger.kernel.org>; Sun, 30 Sep 2018 02:35:49 -0700 (PDT)
In-Reply-To: <20180929175931.18448-2-dsahern@kernel.org>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Sat, 29 Sep 2018 10:59:21 -0700
David Ahern <dsahern@kernel.org> wrote:

> From: David Ahern <dsahern@gmail.com>
> 
> Add rtnl_addrdump_req for address dumps using the proper ifaddrmsg
> as the header. Convert existing RTM_GETADDR dumps to use it.
> 
> Signed-off-by: David Ahern <dsahern@gmail.com>

 }
>  
> +int rtnl_addrdump_req(struct rtnl_handle *rth, int family)
> +{
> +	struct {
> +		struct nlmsghdr nlh;
> +		struct ifaddrmsg ifm;
> +	} req = {
> +		.nlh.nlmsg_len = sizeof(req),
> +		.nlh.nlmsg_type = RTM_GETADDR,
> +		.nlh.nlmsg_flags = NLM_F_DUMP | NLM_F_REQUEST,
> +		.nlh.nlmsg_seq = rth->dump = ++rth->seq,
> +		.ifm.ifa_family = family,
> +	};


This could be:
	} req = {
		.nlh = {
			.nlmsg_len = sizeof(req),
			.nlmsg_type = RTM_GETADDR,
...