From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] team: set IFF_SLAVE on team ports Date: Sun, 30 Sep 2018 11:38:05 +0200 Message-ID: <20180930113805.3b8e62a1@shemminger-XPS-13-9360> References: <1436435914-8903-1-git-send-email-jblunck@infradead.org> <20150709100727.GE2270@nanopsycho.orion> <20150710064147.GA2204@nanopsycho.orion> <20180930071414.GF2209@nanopsycho.orion> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Chas Williams <3chas3@gmail.com>, Jan Blunck , LKML , netdev@vger.kernel.org To: Jiri Pirko Return-path: Received: from mail-wm1-f68.google.com ([209.85.128.68]:33457 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727939AbeI3QK1 (ORCPT ); Sun, 30 Sep 2018 12:10:27 -0400 Received: by mail-wm1-f68.google.com with SMTP id y140-v6so424182wmd.0 for ; Sun, 30 Sep 2018 02:38:10 -0700 (PDT) In-Reply-To: <20180930071414.GF2209@nanopsycho.orion> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, 30 Sep 2018 09:14:14 +0200 Jiri Pirko wrote: > Thu, Sep 27, 2018 at 04:04:26PM CEST, 3chas3@gmail.com wrote: > > > > > >On 07/10/15 02:41, Jiri Pirko wrote: > >> Thu, Jul 09, 2015 at 05:36:55PM CEST, jblunck@infradead.org wrote: > >> > On Thu, Jul 9, 2015 at 12:07 PM, Jiri Pirko wrote: > >> > > Thu, Jul 09, 2015 at 11:58:34AM CEST, jblunck@infradead.org wrote: > >> > > > The code in net/ipv6/addrconf.c:addrconf_notify() tests for IFF_SLAVE to > >> > > > decide if it should start the address configuration. Since team ports > >> > > > shouldn't get link-local addresses assigned lets set IFF_SLAVE when linking > >> > > > a port to the team master. > >> > > > >> > > I don't want to use IFF_SLAVE in team. Other master-slave devices are > >> > > not using that as well, for example bridge, ovs, etc. > >> > > > >> > > >> > Maybe they need to get fixed too. I've used that flag because it is > >> > documented as > >> > a "slave of a load balancer" which describes what a team port is. > >> > > >> > > >> > > I think that this should be fixed in addrconf_notify. It should lookup > >> > > if there is a master on top and bail out in that case. > >> > > >> > There are other virtual interfaces that have a master assigned and want to > >> > participate in IPv6 address configuration. > >> > >> Can you give me an example? > > > >I would like to revisit this patch (yes, I know it has been a while). I > >believe the VRF implementation uses master to group the interfaces under > >a single interface. > > > >I don't see a reason not to use IFF_SLAVE since team and bonding are fairly > >similar. > > Again, why do you need team port to have IFF_SLAVE flag? What do you > want to achieve Without setting this flag IPv6 will try and make a link specific address.