From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daan Wendelen Subject: Re: [PATCH net v2] r8169: always autoneg on resume Date: Mon, 1 Oct 2018 00:17:51 +0200 Message-ID: <20180930221751.rd7wva3zolephj6q@scappy> References: <1538319728.z22jaatdgh.astroid@alex-desktop.none> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, hkallweit1@gmail.com, nic_swsd@realtek.com, davem@davemloft.net, linux-kernel@vger.kernel.org To: "Alex Xu (Hello71)" Return-path: Received: from mail-ed1-f66.google.com ([209.85.208.66]:45572 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726069AbeJAEwi (ORCPT ); Mon, 1 Oct 2018 00:52:38 -0400 Content-Disposition: inline In-Reply-To: <1538319728.z22jaatdgh.astroid@alex-desktop.none> Sender: netdev-owner@vger.kernel.org List-ID: Hi Alex, I randomly opened your patch even though I have absolutely no idea what this patch is about, but I found a mistake in one of the comments: On Sun, Sep 30, 2018 at 11:06:39AM -0400, Alex Xu (Hello71) wrote: > This affects at least versions 25 and 33, so assume all cards are broken ... > * 1GBit link after resuming from S3. For whatever reason the PHY on > - * this chip doesn't properly start a renegotiation when soft-reset. > + * these chips doesn't properly start a renegotiation when soft-reset. ~~~~~~~ I believe it should be "these chips don't" With kind regards, Daan