From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daan Wendelen Subject: Re: [PATCH net v2] r8169: always autoneg on resume Date: Mon, 1 Oct 2018 07:33:04 +0200 Message-ID: <20181001053304.sf64cx7lhot347yz@scappy> References: <1538319728.z22jaatdgh.astroid@alex-desktop.none> <20180930221751.rd7wva3zolephj6q@scappy> <153834665886.421.6376790866713055481@pink.alxu.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, hkallweit1@gmail.com, nic_swsd@realtek.com, davem@davemloft.net, linux-kernel@vger.kernel.org To: Alex Xu Return-path: Content-Disposition: inline In-Reply-To: <153834665886.421.6376790866713055481@pink.alxu.ca> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Sun, Sep 30, 2018 at 10:30:58PM +0000, Alex Xu wrote: > Quoting Daan Wendelen (2018-09-30 22:17:51) > > Hi Alex, > > > > I randomly opened your patch even though I have absolutely no idea what this patch is about, but I > > found a mistake in one of the comments: > > > > On Sun, Sep 30, 2018 at 11:06:39AM -0400, Alex Xu (Hello71) wrote: > > > This affects at least versions 25 and 33, so assume all cards are broken > > ... > > > * 1GBit link after resuming from S3. For whatever reason the PHY on > > > - * this chip doesn't properly start a renegotiation when soft-reset. > > > + * these chips doesn't properly start a renegotiation when soft-reset. > > ~~~~~~~ > > I believe it should be "these chips don't" > > > > With kind regards, > > Daan > > The grammar is correct as is. The subject of the sentence is "the PHY", > which is singular. You are right, I misread the patch. I thought that "these chips" was the subject, but I believe "the PHY on these chips" is the subject. > However, I think it should be "the PHYs" instead, > assuming that they are different. I can't say. I say we leave it as it is because the comment will look good enough.