From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [PATCH v3 net-next 9/9] devlink: Add Documentation/networking/devlink-params-bnxt.txt Date: Mon, 1 Oct 2018 08:49:32 +0200 Message-ID: <20181001064932.GH2209@nanopsycho.orion> References: <1538116103-12356-1-git-send-email-vasundhara-v.volam@broadcom.com> <1538116103-12356-10-git-send-email-vasundhara-v.volam@broadcom.com> <20180929125303.GE2209@nanopsycho.orion> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Miller , "michael.chan@broadcom.com" , Netdev , Jiri Pirko , jakub.kicinski@netronome.com To: Vasundhara Volam Return-path: Received: from mail-wm1-f66.google.com ([209.85.128.66]:50481 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727339AbeJANac (ORCPT ); Mon, 1 Oct 2018 09:30:32 -0400 Received: by mail-wm1-f66.google.com with SMTP id s12-v6so7541137wmc.0 for ; Sun, 30 Sep 2018 23:54:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Mon, Oct 01, 2018 at 06:04:08AM CEST, vasundhara-v.volam@broadcom.com wrote: >On Sat, Sep 29, 2018 at 6:27 PM Jiri Pirko wrote: >> >> Fri, Sep 28, 2018 at 08:28:23AM CEST, vasundhara-v.volam@broadcom.com wrote: >> >This patch adds a new file to add information about configuration >> >parameters that are supported by bnxt_en driver via devlink. >> > >> >Cc: "David S. Miller" >> >Cc: Jonathan Corbet >> >Cc: linux-doc@vger.kernel.org >> >Cc: Jiri Pirko >> >Cc: Michael Chan >> >Signed-off-by: Vasundhara Volam >> >--- >> > Documentation/networking/devlink-params-bnxt.txt | 22 ++++++++++++++++++++++ >> > 1 file changed, 22 insertions(+) >> > create mode 100644 Documentation/networking/devlink-params-bnxt.txt >> > >> >diff --git a/Documentation/networking/devlink-params-bnxt.txt b/Documentation/networking/devlink-params-bnxt.txt >> >new file mode 100644 >> >index 0000000..c7bc9d8 >> >--- /dev/null >> >+++ b/Documentation/networking/devlink-params-bnxt.txt >> >@@ -0,0 +1,22 @@ >> >+enable_sriov [DEVICE, GENERIC] >> >+ Type: Boolean >> >> No need to list "Type" here. You have it in devlink-params.txt for >> generic params already. >Ok, I thought type will give clarity when configuration mode is listed and >when user checks out only driver specific readme file. >I can remove it in next version of patchset. Yes please. The thing is, once this info is on 2 places, I'm pretty sure what eventually there would be different types on different places. Leaving the type only on one place reduces need for sync. Thanks. >> >> >> >+ Configuration mode: Permanent >> >+ >> >+ignore_ari [DEVICE, GENERIC] >> >+ Type: Boolean >> >+ Configuration mode: Permanent >> >+ >> >+msix_vec_per_pf_max [DEVICE, GENERIC] >> >+ Type: u32 >> >+ Configuration mode: Permanent >> >+ >> >+msix_vec_per_pf_min [DEVICE, GENERIC] >> >+ Type: u32 >> >+ Configuration mode: Permanent >> >+ >> >+gre_ver_check [DEVICE, DRIVER-SPECIFIC] >> >+ Generic Routing Encapsulation (GRE) version check will >> >+ be enabled in the device. If disabled, device skips >> >+ version checking for incoming packets. >> >+ Type: Boolean >> >+ Configuration mode: Permanent >> >-- >> >1.8.3.1 >> >