From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2/net-next v2] tc_util: Add support for showing
 TCA_STATS_BASIC_HW statistics
Date: Mon, 1 Oct 2018 11:10:51 +0200
Message-ID: <20181001111051.44f1253b@shemminger-XPS-13-9360>
References: <20180810115846.15762.3693.stgit@wsfd-netdev20.ntdv.lab.eng.bos.redhat.com>
        <20180810074454.4af9e5cd@xeon-e3>
        <52262814-6824-44EF-B10C-C7AD96A0FA57@redhat.com>
        <4203077A-F558-4C2A-82B2-0B0AA8884240@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: netdev@vger.kernel.org, davem@davemloft.net
To: "Eelco Chaudron" <echaudro@redhat.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-ed1-f67.google.com ([209.85.208.67]:44251 "EHLO
        mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729006AbeJAPro (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 1 Oct 2018 11:47:44 -0400
Received: by mail-ed1-f67.google.com with SMTP id t11-v6so13471868edq.11
        for <netdev@vger.kernel.org>; Mon, 01 Oct 2018 02:10:57 -0700 (PDT)
In-Reply-To: <4203077A-F558-4C2A-82B2-0B0AA8884240@redhat.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Mon, 01 Oct 2018 09:08:32 +0200
"Eelco Chaudron" <echaudro@redhat.com> wrote:

> On 10 Aug 2018, at 16:48, Eelco Chaudron wrote:
>=20
> > On 10 Aug 2018, at 16:44, Stephen Hemminger wrote:
> > =20
> >> On Fri, 10 Aug 2018 07:59:30 -0400
> >> Eelco Chaudron <echaudro@redhat.com> wrote:
> >> =20
> >>> +		if (bs.bytes >=3D bs_hw.bytes && bs.packets >=3D bs_hw.packets) {
> >>> +			print_string(PRINT_FP, NULL, "%s", _SL_);
> >>> +			print_string(PRINT_FP, NULL, "%s", prefix);
> >>> +			print_lluint(PRINT_ANY, "sw_bytes",
> >>> +				     "Sent software %llu bytes",
> >>> +				     bs.bytes - bs_hw.bytes);
> >>> +			print_uint(PRINT_ANY, "sw_packets", " %u pkt",
> >>> +				   bs.packets - bs_hw.packets);
> >>> +		}
> >>> +	}
> >>> +
> >>> +	print_string(PRINT_FP, NULL, "%s", _SL_);
> >>> +	print_string(PRINT_FP, NULL, "%s", prefix);
> >>> +	print_lluint(PRINT_ANY, "hw_bytes", "Sent hardware %llu bytes",
> >>> +		     bs_hw.bytes); =20
> >>
> >> What does the output look like? =20
> >
> > See the two +=E2=80=99es below:
> >
> > $ tc -s filter show dev enp3s0np0 parent ffff:
> > filter protocol ip pref 1 flower chain 0
> > filter protocol ip pref 1 flower chain 0 handle 0x1
> >   eth_type ipv4
> >   dst_ip 2.0.0.0
> >   src_ip 1.0.0.0
> >   ip_flags nofrag
> >   in_hw
> >         action order 1: mirred (Egress Redirect to device eth1) stolen
> >         index 1 ref 1 bind 1 installed 0 sec used 0 sec
> >         Action statistics:
> >         Sent 534884742 bytes 8915697 pkt (dropped 0, overlimits 0=20
> > requeues 0)
> > +       Sent software 187542 bytes 4077 pkt
> > +       Sent hardware 534697200 bytes 8911620 pkt
> >         backlog 0b 0p requeues 0
> >         cookie 89173e6a44447001becfd486bda17e29 =20
>=20
> Hi Stephen, anything else required for this patch to be accepted?
>=20
> FYI the kernel side of this patch has been excepted on net-next.
>=20
> Cheers,
>=20
> Eelco

David Ahern handles net-next see patchwork
  https://patchwork.ozlabs.org/patch/956225/

I think he was just waiting for the kernel part to merge.