From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH] ipw2x00: Remove unnecessary parentheses Date: Mon, 1 Oct 2018 15:30:47 +0000 (UTC) Message-ID: <20181001153047.4102060B7A@smtp.codeaurora.org> References: <20180920204548.2405-1-natechancellor@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: Stanislav Yakovlev , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Nathan Chancellor To: Nathan Chancellor Return-path: In-Reply-To: <20180920204548.2405-1-natechancellor@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Nathan Chancellor wrote: > Clang warns when multiple pairs of parentheses are used for a single > conditional statement. > > drivers/net/wireless/intel/ipw2x00/ipw2200.c:5655:28: warning: equality > comparison with extraneous parentheses [-Wparentheses-equality] > if ((priv->ieee->iw_mode == IW_MODE_ADHOC)) { > ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~ > drivers/net/wireless/intel/ipw2x00/ipw2200.c:5655:28: note: remove > extraneous parentheses around the comparison to silence this warning > if ((priv->ieee->iw_mode == IW_MODE_ADHOC)) { > ~ ^ ~ > drivers/net/wireless/intel/ipw2x00/ipw2200.c:5655:28: note: use '=' to > turn this equality comparison into an assignment > if ((priv->ieee->iw_mode == IW_MODE_ADHOC)) { > ^~ > = > 1 warning generated. > > Link: https://github.com/ClangBuiltLinux/linux/issues/134 > Signed-off-by: Nathan Chancellor Patch applied to wireless-drivers-next.git, thanks. c15ace868dd1 ipw2x00: Remove unnecessary parentheses -- https://patchwork.kernel.org/patch/10608735/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches