From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH] rsi: Remove unnecessary boolean condition Date: Mon, 1 Oct 2018 15:32:02 +0000 (UTC) Message-ID: <20181001153202.C727D60C86@smtp.codeaurora.org> References: <20180921094828.16976-1-natechancellor@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Nathan Chancellor To: Nathan Chancellor Return-path: In-Reply-To: <20180921094828.16976-1-natechancellor@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Nathan Chancellor wrote: > Clang warns that the address of a pointer will always evaluated as true > in a boolean context. > > drivers/net/wireless/rsi/rsi_91x_mac80211.c:927:50: warning: address of > array 'key->key' will always evaluate to 'true' > [-Wpointer-bool-conversion] > if (vif->type == NL80211_IFTYPE_STATION && key->key && > ~~ ~~~~~^~~ > 1 warning generated. > > Link: https://github.com/ClangBuiltLinux/linux/issues/136 > Signed-off-by: Nathan Chancellor Patch applied to wireless-drivers-next.git, thanks. f613e4803dd6 rsi: Remove unnecessary boolean condition -- https://patchwork.kernel.org/patch/10609513/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches