From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH v2] ath5k: Remove unused BUG_ON Date: Mon, 1 Oct 2018 15:36:32 +0000 (UTC) Message-ID: <20181001153632.BBA9460BF4@smtp.codeaurora.org> References: <20180921193235.1723-1-natechancellor@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: Jiri Slaby , Nick Kossifidis , "Luis R. Rodriguez" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Nathan Chancellor To: Nathan Chancellor Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:38062 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725266AbeJAWOz (ORCPT ); Mon, 1 Oct 2018 18:14:55 -0400 In-Reply-To: <20180921193235.1723-1-natechancellor@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: Nathan Chancellor wrote: > Clang warns that the address of a pointer will always evaluated as true > in a boolean context: > > drivers/net/wireless/ath/ath5k/debug.c:1031:14: warning: address of > array 'ah->sbands' will always evaluate to 'true' > [-Wpointer-bool-conversion] > BUG_ON(!ah->sbands); > ~~~~~^~~~~~ > ./include/asm-generic/bug.h:61:45: note: expanded from macro 'BUG_ON' > #define BUG_ON(condition) do { if (unlikely(condition)) BUG(); } while (0) > ^~~~~~~~~ > ./include/linux/compiler.h:77:42: note: expanded from macro 'unlikely' > # define unlikely(x) __builtin_expect(!!(x), 0) > ^ > 1 warning generated. > > Given that this condition is always false because of the logical not, > just remove it. > > Link: https://github.com/ClangBuiltLinux/linux/issues/130 > Signed-off-by: Nathan Chancellor Patch applied to wireless-drivers-next.git, thanks. 0891c7f4a253 ath5k: Remove unused BUG_ON -- https://patchwork.kernel.org/patch/10610881/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches