From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Subject: Re: [PATCH v2] rtlwifi: btcoex: Use proper enumerated types for Wi-Fi only interface Date: Mon, 1 Oct 2018 15:37:09 +0000 (UTC) Message-ID: <20181001153709.6C74A601A0@smtp.codeaurora.org> References: <20180923063114.11446-1-natechancellor@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Cc: Ping-Ke Shih , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Nathan Chancellor To: Nathan Chancellor Return-path: In-Reply-To: <20180923063114.11446-1-natechancellor@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Nathan Chancellor wrote: > Clang warns when one enumerated type is implicitly converted to another. > > drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1327:34: > warning: implicit conversion from enumeration type 'enum > btc_chip_interface' to different enumeration type 'enum > wifionly_chip_interface' [-Wenum-conversion] > wifionly_cfg->chip_interface = BTC_INTF_PCI; > ~ ^~~~~~~~~~~~ > drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1330:34: > warning: implicit conversion from enumeration type 'enum > btc_chip_interface' to different enumeration type 'enum > wifionly_chip_interface' [-Wenum-conversion] > wifionly_cfg->chip_interface = BTC_INTF_USB; > ~ ^~~~~~~~~~~~ > drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtcoutsrc.c:1333:34: > warning: implicit conversion from enumeration type 'enum > btc_chip_interface' to different enumeration type 'enum > wifionly_chip_interface' [-Wenum-conversion] > wifionly_cfg->chip_interface = BTC_INTF_UNKNOWN; > ~ ^~~~~~~~~~~~~~~~ > 3 warnings generated. > > Use the values from the correct enumerated type, wifionly_chip_interface. > > BTC_INTF_UNKNOWN = WIFIONLY_INTF_UNKNOWN = 0 > BTC_INTF_PCI = WIFIONLY_INTF_PCI = 1 > BTC_INTF_USB = WIFIONLY_INTF_USB = 2 > > Link: https://github.com/ClangBuiltLinux/linux/issues/135 > Signed-off-by: Nathan Chancellor > Acked-by: Ping-Ke Shih Patch applied to wireless-drivers-next.git, thanks. 31138a827d1b rtlwifi: btcoex: Use proper enumerated types for Wi-Fi only interface -- https://patchwork.kernel.org/patch/10611603/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches