From: David Miller <davem@davemloft.net>
To: mmanning@vyatta.att-mail.com
Cc: netdev@vger.kernel.org, fw@strlen.de
Subject: Re: [PATCH net] ipv6: revert degradation in IPv6 Ready Logo test results
Date: Tue, 02 Oct 2018 11:26:00 -0700 (PDT) [thread overview]
Message-ID: <20181002.112600.2116388713222602539.davem@davemloft.net> (raw)
In-Reply-To: <20181002114030.18152-1-mmanning@vyatta.att-mail.com>
From: Mike Manning <mmanning@vyatta.att-mail.com>
Date: Tue, 2 Oct 2018 12:40:30 +0100
> This reverts commit 0ed4229b08c1 ("ipv6: defrag: drop non-last frags
> smaller than min mtu"). While one should not get fragments smaller than
> the IPv6 minimum MTU, not handling crafted packets in the TAHI IPv6
> conformance test suite (v6eval) for IPv6 Ready Logo results in 18
> failures representing over 5% of the score.
>
> Cc: Florian Westphal <fw@strlen.de>
> Signed-off-by: Mike Manning <mmanning@vyatta.att-mail.com>
Sorry, I'm not just going to blindly apply a patch because some
TAHI tests fail.
It's possible the TAHI tests are wrong, or that the specification
elements it is testing don't make any sense these days.
Allowing all kinds of random junk in the middle of the fragment queue
leads to lots of unnecessary cpu overhead and potential bugs, and it
triggerable remotely.
next prev parent reply other threads:[~2018-10-03 1:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 11:40 [PATCH net] ipv6: revert degradation in IPv6 Ready Logo test results Mike Manning
2018-10-02 18:26 ` David Miller [this message]
2018-10-03 7:56 ` Mike Manning
2018-10-03 8:16 ` 吉藤英明
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181002.112600.2116388713222602539.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fw@strlen.de \
--cc=mmanning@vyatta.att-mail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).