From: David Miller <davem@davemloft.net>
To: edumazet@google.com
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH net] inet: make sure to grab rcu_read_lock before using ireq->ireq_opt
Date: Tue, 02 Oct 2018 15:52:36 -0700 (PDT) [thread overview]
Message-ID: <20181002.155236.1859184270596107590.davem@davemloft.net> (raw)
In-Reply-To: <20181002193505.48167-1-edumazet@google.com>
From: Eric Dumazet <edumazet@google.com>
Date: Tue, 2 Oct 2018 12:35:05 -0700
> Timer handlers do not imply rcu_read_lock(), so my recent fix
> triggered a LOCKDEP warning when SYNACK is retransmit.
>
> Lets add rcu_read_lock()/rcu_read_unlock() pairs around ireq->ireq_opt
> usages instead of guessing what is done by callers, since it is
> not worth the pain.
>
> Get rid of ireq_opt_deref() helper since it hides the logic
> without real benefit, since it is now a standard rcu_dereference().
>
> Fixes: 1ad98e9d1bdf ("tcp/dccp: fix lockdep issue when SYN is backlogged")
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Reported-by: Willem de Bruijn <willemb@google.com>
Applied, thanks Eric.
prev parent reply other threads:[~2018-10-03 5:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 19:35 [PATCH net] inet: make sure to grab rcu_read_lock before using ireq->ireq_opt Eric Dumazet
2018-10-02 22:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181002.155236.1859184270596107590.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).