* [PATCH net] bonding: fix warning message
@ 2018-10-02 19:14 Mahesh Bandewar
2018-10-02 22:55 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Mahesh Bandewar @ 2018-10-02 19:14 UTC (permalink / raw)
To: Jay Vosburgh, Andy Gospodarek, Veaceslav Falico, David Miller
Cc: Mahesh Bandewar, Netdev, Eric Dumazet, Mahesh Bandewar
From: Mahesh Bandewar <maheshb@google.com>
RX queue config for bonding master could be different from its slave
device(s). With the commit 6a9e461f6fe4 ("bonding: pass link-local
packets to bonding master also."), the packet is reinjected into stack
with skb->dev as bonding master. This potentially triggers the
message:
"bondX received packet on queue Y, but number of RX queues is Z"
whenever the queue that packet is received on is higher than the
numrxqueues on bonding master (Y > Z).
Fixes: 6a9e461f6fe4 ("bonding: pass link-local packets to bonding master also.")
Reported-by: John Sperbeck <jsperbeck@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Mahesh Bandewar <maheshb@google.com>
---
drivers/net/bonding/bond_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index c05c01a00755..ee28ec9e0aba 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -1187,6 +1187,7 @@ static rx_handler_result_t bond_handle_frame(struct sk_buff **pskb)
if (nskb) {
nskb->dev = bond->dev;
+ nskb->queue_mapping = 0;
netif_rx(nskb);
}
return RX_HANDLER_PASS;
--
2.19.0.605.g01d371f741-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] bonding: fix warning message
2018-10-02 19:14 [PATCH net] bonding: fix warning message Mahesh Bandewar
@ 2018-10-02 22:55 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-10-02 22:55 UTC (permalink / raw)
To: mahesh; +Cc: j.vosburgh, andy, vfalico, netdev, edumazet, maheshb
From: Mahesh Bandewar <mahesh@bandewar.net>
Date: Tue, 2 Oct 2018 12:14:34 -0700
> From: Mahesh Bandewar <maheshb@google.com>
>
> RX queue config for bonding master could be different from its slave
> device(s). With the commit 6a9e461f6fe4 ("bonding: pass link-local
> packets to bonding master also."), the packet is reinjected into stack
> with skb->dev as bonding master. This potentially triggers the
> message:
>
> "bondX received packet on queue Y, but number of RX queues is Z"
>
> whenever the queue that packet is received on is higher than the
> numrxqueues on bonding master (Y > Z).
>
> Fixes: 6a9e461f6fe4 ("bonding: pass link-local packets to bonding master also.")
> Reported-by: John Sperbeck <jsperbeck@google.com>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-03 5:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-02 19:14 [PATCH net] bonding: fix warning message Mahesh Bandewar
2018-10-02 22:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).