From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] bridge: mcast: Default back to multicast enabled state Date: Tue, 02 Oct 2018 22:27:51 -0700 (PDT) Message-ID: <20181002.222751.1282381500734131142.davem@davemloft.net> References: <20181001085701.23295-1-idosch@mellanox.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, nikolay@cumulusnetworks.com, roopa@cumulusnetworks.com, bridge@lists.linux-foundation.org, mlxsw@mellanox.com To: idosch@mellanox.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:54584 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726405AbeJCMOk (ORCPT ); Wed, 3 Oct 2018 08:14:40 -0400 In-Reply-To: <20181001085701.23295-1-idosch@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Ido Schimmel Date: Mon, 1 Oct 2018 11:57:01 +0300 > Commit 13cefad2f2c1 ("net: bridge: convert and rename mcast disabled") > converted the 'multicast_disabled' field to an option bit named > 'BROPT_MULTICAST_ENABLED'. > > While the old field was implicitly initialized to 0, the new field is > not initialized, resulting in the bridge defaulting to multicast > disabled state and breaking existing applications. > > Fix this by explicitly initializing the option. > > Fixes: 13cefad2f2c1 ("net: bridge: convert and rename mcast disabled") > Signed-off-by: Ido Schimmel Applied.