From: David Miller <davem@davemloft.net>
To: natechancellor@gmail.com
Cc: ganeshgr@chelsio.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ndesaulniers@google.com
Subject: Re: [PATCH] cxgb4: Use proper enum in cxgb4_dcb_handle_fw_update
Date: Tue, 02 Oct 2018 22:31:36 -0700 (PDT) [thread overview]
Message-ID: <20181002.223136.2270087424787695690.davem@davemloft.net> (raw)
In-Reply-To: <20181001035143.30670-1-natechancellor@gmail.com>
From: Nathan Chancellor <natechancellor@gmail.com>
Date: Sun, 30 Sep 2018 20:51:43 -0700
> Clang warns when one enumerated type is implicitly converted to another.
>
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c:303:7: warning: implicit
> conversion from enumeration type 'enum cxgb4_dcb_state' to different
> enumeration type 'enum cxgb4_dcb_state_input' [-Wenum-conversion]
> ? CXGB4_DCB_STATE_FW_ALLSYNCED
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
> drivers/net/ethernet/chelsio/cxgb4/cxgb4_dcb.c:304:7: warning: implicit
> conversion from enumeration type 'enum cxgb4_dcb_state' to different
> enumeration type 'enum cxgb4_dcb_state_input' [-Wenum-conversion]
> : CXGB4_DCB_STATE_FW_INCOMPLETE);
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 2 warnings generated.
>
> Use the equivalent value of the expected type to silence Clang while
> resulting in no functional change.
>
> CXGB4_DCB_STATE_FW_INCOMPLETE = CXGB4_DCB_INPUT_FW_INCOMPLETE = 2
> CXGB4_DCB_STATE_FW_ALLSYNCED = CXGB4_DCB_INPUT_FW_ALLSYNCED = 3
>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Applied to net-next.
prev parent reply other threads:[~2018-10-03 5:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 3:51 [PATCH] cxgb4: Use proper enum in cxgb4_dcb_handle_fw_update Nathan Chancellor
2018-10-02 22:54 ` Nick Desaulniers
2018-10-03 5:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181002.223136.2270087424787695690.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ganeshgr@chelsio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox