From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: [PATCH RFC v2 net-next 25/25] net: Enable kernel side filtering of route dumps Date: Mon, 1 Oct 2018 17:28:51 -0700 Message-ID: <20181002002851.5002-26-dsahern@kernel.org> References: <20181002002851.5002-1-dsahern@kernel.org> Cc: christian@brauner.io, jbenc@redhat.com, stephen@networkplumber.org, David Ahern To: netdev@vger.kernel.org, davem@davemloft.net Return-path: Received: from mail.kernel.org ([198.145.29.99]:35286 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726537AbeJBHJW (ORCPT ); Tue, 2 Oct 2018 03:09:22 -0400 In-Reply-To: <20181002002851.5002-1-dsahern@kernel.org> Sender: netdev-owner@vger.kernel.org List-ID: From: David Ahern Update parsing of route dump request to enable kernel side of filtering. Signed-off-by: David Ahern --- net/ipv4/fib_frontend.c | 42 ++++++++++++++++++++++++++++++------------ 1 file changed, 30 insertions(+), 12 deletions(-) diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c index a3f4073e509a..d1ef1cb98139 100644 --- a/net/ipv4/fib_frontend.c +++ b/net/ipv4/fib_frontend.c @@ -806,7 +806,9 @@ int ip_valid_fib_dump_req(const struct nlmsghdr *nlh, struct fib_dump_filter *filter, struct netlink_ext_ack *extack) { + struct nlattr *tb[RTA_MAX + 1]; struct rtmsg *rtm; + int err, i; if (nlh->nlmsg_len < nlmsg_msg_size(sizeof(*rtm))) { NL_SET_ERR_MSG(extack, "Invalid header"); @@ -814,21 +816,37 @@ int ip_valid_fib_dump_req(const struct nlmsghdr *nlh, } rtm = nlmsg_data(nlh); - if (rtm->rtm_dst_len || rtm->rtm_src_len || rtm->rtm_tos || - rtm->rtm_table || rtm->rtm_protocol || rtm->rtm_scope || - rtm->rtm_type) { - NL_SET_ERR_MSG(extack, - "Invalid values in header for dump request"); + if (rtm->rtm_dst_len || rtm->rtm_src_len) { + NL_SET_ERR_MSG(extack, "Invalid values in header for dump request"); return -EINVAL; } - if (rtm->rtm_flags & ~(RTM_F_CLONED | RTM_F_PREFIX)) { - NL_SET_ERR_MSG(extack, "Invalid flags for dump request"); - return -EINVAL; - } - if (nlh->nlmsg_len != nlmsg_msg_size(sizeof(*rtm))) { - NL_SET_ERR_MSG(extack, "Invalid data after header"); - return -EINVAL; + filter->flags = rtm->rtm_flags; + filter->tos = rtm->rtm_tos; + filter->protocol = rtm->rtm_protocol; + filter->scope = rtm->rtm_scope; + filter->rt_type = rtm->rtm_type; + filter->table_id = rtm->rtm_table; + + err = nlmsg_parse(nlh, sizeof(*rtm), tb, RTA_MAX, + rtm_ipv4_policy, extack); + if (err < 0) + return err; + + for (i = 0; i <= RTA_MAX; ++i) { + if (!tb[i]) + continue; + switch (i) { + case RTA_TABLE: + filter->table_id = nla_get_u32(tb[i]); + break; + case RTA_OIF: + filter->ifindex = nla_get_u32(tb[i]); + break; + default: + NL_SET_ERR_MSG(extack, "Unsupported attribute in dump request"); + return -EINVAL; + } } return 0; -- 2.11.0