From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Subject: Re: [RFC v2 bpf-next 3/5] tools/bpf: bpftool, split the function do_dump() Date: Tue, 2 Oct 2018 10:02:15 -0700 Message-ID: <20181002100215.70160204@cakuba.netronome.com> References: <20181002053519.8000-1-bhole_prashant_q7@lab.ntt.co.jp> <20181002053519.8000-4-bhole_prashant_q7@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Alexei Starovoitov , Daniel Borkmann , "David S . Miller" , Quentin Monnet , netdev@vger.kernel.org To: Prashant Bhole Return-path: Received: from mail-qk1-f179.google.com ([209.85.222.179]:39178 "EHLO mail-qk1-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726761AbeJBXqk (ORCPT ); Tue, 2 Oct 2018 19:46:40 -0400 Received: by mail-qk1-f179.google.com with SMTP id q5-v6so1592922qki.6 for ; Tue, 02 Oct 2018 10:02:19 -0700 (PDT) In-Reply-To: <20181002053519.8000-4-bhole_prashant_q7@lab.ntt.co.jp> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2 Oct 2018 14:35:17 +0900, Prashant Bhole wrote: > do_dump() function in bpftool/map.c has deep indentations. In order > to reduce deep indent, let's move element printing code out of > do_dump() into dump_map_elem() function. > > Signed-off-by: Prashant Bhole Acked-by: Jakub Kicinski