From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Benc Subject: Re: [PATCH RFC v2 net-next 02/25] net/ipv6: Refactor address dump to push inet6_fill_args to in6_dump_addrs Date: Tue, 2 Oct 2018 18:24:03 +0200 Message-ID: <20181002182403.2144ce03@redhat.com> References: <20181002002851.5002-1-dsahern@kernel.org> <20181002002851.5002-3-dsahern@kernel.org> <20181002125425.35e96876@redhat.com> <1a37ac7e-8291-e3f2-c1f3-724c72f2b466@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: David Ahern , netdev@vger.kernel.org, davem@davemloft.net, christian@brauner.io, stephen@networkplumber.org To: David Ahern Return-path: Received: from mx1.redhat.com ([209.132.183.28]:45078 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727351AbeJBXIR (ORCPT ); Tue, 2 Oct 2018 19:08:17 -0400 In-Reply-To: <1a37ac7e-8291-e3f2-c1f3-724c72f2b466@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2 Oct 2018 09:11:17 -0600, David Ahern wrote: > Generically speaking a filter modifies the output based on the input. > Specifying a target namespace is an input to the dump that modifies the > output. That's conventionally called "algorithm" :-) Let's just say we have a different understanding of what "filter" is. Perhaps we should look at it from a different side. What is the use case of having NLM_F_DUMP_FILTERED set for IFA_TARGET_NETNSID? How is this going to be used by applications? > Yes, you can do it in userspace which is what iproute2 has done to this > point, but it is grossly inefficient and that inefficiency has > implications at scale. You can't do that with IFA_TARGET_NETNSID. Which is my point. Without the flag, you don't get a list of all interfaces in all net name spaces. Jiri