From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Benc Subject: Re: [PATCH RFC v2 net-next 03/25] netlink: introduce NLM_F_DUMP_PROPER_HDR flag Date: Tue, 2 Oct 2018 18:30:18 +0200 Message-ID: <20181002183018.65c41753@redhat.com> References: <20181002002851.5002-1-dsahern@kernel.org> <20181002002851.5002-4-dsahern@kernel.org> <20181002130614.77856ff8@redhat.com> <20181002111831.j6ov4bqhy3zi3vj6@brauner.io> <20181002132755.267a11fe@redhat.com> <6d1380b4-217c-387b-7e44-efaa8d091108@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Christian Brauner , David Ahern , netdev@vger.kernel.org, davem@davemloft.net, stephen@networkplumber.org To: David Ahern Return-path: Received: from mx1.redhat.com ([209.132.183.28]:40490 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726691AbeJBXOe (ORCPT ); Tue, 2 Oct 2018 19:14:34 -0400 In-Reply-To: <6d1380b4-217c-387b-7e44-efaa8d091108@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, 2 Oct 2018 08:57:24 -0600, David Ahern wrote: > You can when you introduce a new option or a new flag that is required > to get new behavior like kernel side filtering. Yes. That was what I tried with the patchset a few years back. It would be nice to revive the effort. > I chose a netlink flag for consistency with NLM_F_DUMP_INTR and > NLM_F_DUMP_FILTERED. Both are netlink flags. This patch set fixes only > what is broken -- dumps. When we're introducing better input checking in netlink (which is a good thing!), it would be good to do it consistently and have it generic across all operations. Jiri