From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH iproute2] lib/libnetlink: fix response seq check
Date: Wed, 3 Oct 2018 16:50:31 -0700
Message-ID: <20181003165031.24d3bdc6@xeon-e3>
References: <20180928171339.4332-1-vlad@dumitrescu.ro>
        <CALpBo+WyoSH5o+Vg1j_jjA9e_UeVB=9x7q+szPW330J=zdJWqg@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: chrism@mellanox.com, Mahesh Bandewar <maheshb@google.com>,
        netdev@vger.kernel.org, Vlad Dumitrescu <vladum@google.com>
To: Vlad Dumitrescu <vlad@dumitrescu.ro>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pf1-f194.google.com ([209.85.210.194]:44190 "EHLO
        mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725799AbeJDGlI (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 4 Oct 2018 02:41:08 -0400
Received: by mail-pf1-f194.google.com with SMTP id r9-v6so2272895pff.11
        for <netdev@vger.kernel.org>; Wed, 03 Oct 2018 16:50:34 -0700 (PDT)
In-Reply-To: <CALpBo+WyoSH5o+Vg1j_jjA9e_UeVB=9x7q+szPW330J=zdJWqg@mail.gmail.com>
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

On Wed, 3 Oct 2018 16:01:40 -0700
Vlad Dumitrescu <vlad@dumitrescu.ro> wrote:

> Hi,
> 
> On Fri, Sep 28, 2018 at 10:14 AM <vlad@dumitrescu.ro> wrote:
> >
> > From: Vlad Dumitrescu <vladum@google.com>
> >
> > Taking a one-iovec example, with rtnl->seq at 42. iovlen == 1, seq
> > becomes 43 on line 604, and a message is sent with nlmsg_seq == 43. If
> > a response with nlmsg_seq of 42 is received, the condition being fixed
> > in this patch would incorrectly accept it.
> >
> > Fixes: 72a2ff3916e5 ("lib/libnetlink: Add a new function rtnl_talk_iov")
> > Signed-off-by: Vlad Dumitrescu <vladum@google.com>
> > ---
> >  lib/libnetlink.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/libnetlink.c b/lib/libnetlink.c
> > index f18dceac..4d2416bf 100644
> > --- a/lib/libnetlink.c
> > +++ b/lib/libnetlink.c
> > @@ -647,7 +647,7 @@ static int __rtnl_talk_iov(struct rtnl_handle *rtnl, struct iovec *iov,
> >
> >                         if (nladdr.nl_pid != 0 ||
> >                             h->nlmsg_pid != rtnl->local.nl_pid ||
> > -                           h->nlmsg_seq > seq || h->nlmsg_seq < seq - iovlen) {
> > +                           h->nlmsg_seq > seq || h->nlmsg_seq < seq - iovlen + 1) {
> >                                 /* Don't forget to skip that message. */
> >                                 status -= NLMSG_ALIGN(len);
> >                                 h = (struct nlmsghdr *)((char *)h + NLMSG_ALIGN(len));
> > --
> > 2.19.0.605.g01d371f741-goog  
> 
> Did anybody get a chance to review this? I'm not 100% sure I'm fixing
> the right thing.
> 
> Thanks,
> Vlad

Could you give an example where this failed.
Better yet one of the tests.