From mboxrd@z Thu Jan  1 00:00:00 1970
From: David Miller <davem@davemloft.net>
Subject: Re: [PATCH v2] qed: Avoid implicit enum conversion in
 qed_ooo_submit_tx_buffers
Date: Thu, 04 Oct 2018 09:58:45 -0700 (PDT)
Message-ID: <20181004.095845.964782412753569093.davem@davemloft.net>
References: <20181004000912.22242-1-natechancellor@gmail.com>
        <20181004163919.13972-1-natechancellor@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: Ariel.Elior@cavium.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, ndesaulniers@google.com,
        Dept-EngEverestLinuxL2@cavium.com, Tomer.Tayar@cavium.com
To: natechancellor@gmail.com
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20181004163919.13972-1-natechancellor@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

From: Nathan Chancellor <natechancellor@gmail.com>
Date: Thu,  4 Oct 2018 09:39:20 -0700

> Clang warns when one enumerated type is implicitly converted to another.
> 
> drivers/net/ethernet/qlogic/qed/qed_ll2.c:799:32: warning: implicit
> conversion from enumeration type 'enum core_tx_dest' to different
> enumeration type 'enum qed_ll2_tx_dest' [-Wenum-conversion]
>                 tx_pkt.tx_dest = p_ll2_conn->tx_dest;
>                                ~ ~~~~~~~~~~~~^~~~~~~
> 1 warning generated.
> 
> Fix this by using a switch statement to convert between the enumerated
> values since they are not 1 to 1, which matches how the rest of the
> driver handles this conversion.
> 
> Link: https://github.com/ClangBuiltLinux/linux/issues/125
> Suggested-by: Tomer Tayar <Tomer.Tayar@cavium.com>
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> 
> v1 -> v2:
> 
> * Use an explicit switch statement to convert between the enumerated
>   types like the rest of the driver, as suggested by Tomer.

Applied to net-next.