From: David Miller <davem@davemloft.net>
To: 0xeffeff@gmail.com
Cc: netdev@vger.kernel.org
Subject: Re: icmp6_send() is too expensive
Date: Thu, 04 Oct 2018 12:33:43 -0700 (PDT) [thread overview]
Message-ID: <20181004.123343.1000066789406204771.davem@davemloft.net> (raw)
In-Reply-To: <CAL6e_pfLT9Q+Sz+e9L4DyzwatZAWmv+Kz_+HFPK3BOrpbua=wQ@mail.gmail.com>
From: Jeff Barnhill <0xeffeff@gmail.com>
Date: Thu, 4 Oct 2018 15:02:39 -0400
> As mentioned here:
> https://www.spinics.net/lists/netdev/msg505054.html
>
> icmp6_send() can be expensive when there are a lot of devices and
> anycast addresses. One solution I've prototyped is adding a global
> hash table to store and allow more efficient searches for anycast
> addresses. This works and prevents the long delays I've seen when
> many neighbors are invalidated in large numbers.
>
> A colleague mentioned that another alternative may be to do something
> like an rt6_lookup on the address and check for the RTF_ANYCAST flag.
> This is much simpler, and I'm in the process of testing it now.
>
> Is there any preference or recommendation as to which way to proceed
> before I submit a patch?
Generally speaking, using existing tables and infrastructure is
preferrable to adding new stuff.
prev parent reply other threads:[~2018-10-05 2:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 19:02 icmp6_send() is too expensive Jeff Barnhill
2018-10-04 19:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181004.123343.1000066789406204771.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=0xeffeff@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox