From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v4 net-next 0/9] bnxt_en: devlink param updates Date: Thu, 04 Oct 2018 13:50:21 -0700 (PDT) Message-ID: <20181004.135021.719953370786213619.davem@davemloft.net> References: <1538631832-15481-1-git-send-email-vasundhara-v.volam@broadcom.com> <20181004103940.GE2222@nanopsycho> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: vasundhara-v.volam@broadcom.com, gerlitz.or@gmail.com, michael.chan@broadcom.com, netdev@vger.kernel.org, jiri@mellanox.com, jakub.kicinski@netronome.com To: jiri@resnulli.us Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:55850 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727536AbeJEDpX (ORCPT ); Thu, 4 Oct 2018 23:45:23 -0400 In-Reply-To: <20181004103940.GE2222@nanopsycho> Sender: netdev-owner@vger.kernel.org List-ID: From: Jiri Pirko Date: Thu, 4 Oct 2018 12:39:40 +0200 > Thu, Oct 04, 2018 at 07:43:43AM CEST, vasundhara-v.volam@broadcom.com wrote: >>This patchset adds support for 3 generic and 1 driver-specific devlink >>parameters. Add documentation for these configuration parameters. >> >>Also, this patchset adds support to return proper error code if >>HWRM_NVM_GET/SET_VARIABLE commands return error code >>HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED. >> >>v3->v4: >>-Remove extra definition of NVM_OFF_HW_TC_OFFLOAD from bnxt_devlink.h >>-Remove type information for generic parameters from >>devlink-params-bnxt.txt >> >>v2->v3: >>-Remove description of generic parameters from devlink-params-bnxt.txt >> >>v1->v2: >>-Remove hw_tc_offload parameter. >>-Update all patches with Cc of MAINTAINERS. >>-Add more description in commit message for device specific parameter. >>-Add a new Documentation/networking/devlink-params.txt with some >>generic devlink parameters information. >>-Add a new Documentation/networking/devlink-params-bnxt.txt with devlink >>parameters information that are supported by bnxt_en driver. >> >>Vasundhara Volam (9): >> devlink: Add generic parameter ignore_ari >> devlink: Add generic parameter msix_vec_per_pf_max >> devlink: Add generic parameter msix_vec_per_pf_min >> bnxt_en: Use ignore_ari devlink parameter >> bnxt_en: return proper error when FW returns >> HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED >> bnxt_en: Use msix_vec_per_pf_max and msix_vec_per_pf_min devlink >> params. >> bnxt_en: Add a driver specific gre_ver_check devlink parameter. >> devlink: Add Documentation/networking/devlink-params.txt >> devlink: Add Documentation/networking/devlink-params-bnxt.txt > > Looks good to me. For the whole set: > Acked-by: Jiri Pirko Series applied, thanks.