From: David Miller <davem@davemloft.net>
To: yuzhao@google.com
Cc: steve.glendinning@shawell.net, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/usb: cancel pending work when unbinding smsc75xx
Date: Thu, 04 Oct 2018 13:52:02 -0700 (PDT) [thread overview]
Message-ID: <20181004.135202.1340830794025516563.davem@davemloft.net> (raw)
In-Reply-To: <20180928230430.125003-1-yuzhao@google.com>
From: Yu Zhao <yuzhao@google.com>
Date: Fri, 28 Sep 2018 17:04:30 -0600
> Cancel pending work before freeing smsc75xx private data structure
> during binding. This fixes the following crash in the driver:
>
> BUG: unable to handle kernel NULL pointer dereference at 0000000000000050
> IP: mutex_lock+0x2b/0x3f
> <snipped>
> Workqueue: events smsc75xx_deferred_multicast_write [smsc75xx]
> task: ffff8caa83e85700 task.stack: ffff948b80518000
> RIP: 0010:mutex_lock+0x2b/0x3f
> <snipped>
> Call Trace:
> smsc75xx_deferred_multicast_write+0x40/0x1af [smsc75xx]
> process_one_work+0x18d/0x2fc
> worker_thread+0x1a2/0x269
> ? pr_cont_work+0x58/0x58
> kthread+0xfa/0x10a
> ? pr_cont_work+0x58/0x58
> ? rcu_read_unlock_sched_notrace+0x48/0x48
> ret_from_fork+0x22/0x40
>
> Signed-off-by: Yu Zhao <yuzhao@google.com>
Applied and queued up for -stable.
prev parent reply other threads:[~2018-10-04 20:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-28 23:04 [PATCH] net/usb: cancel pending work when unbinding smsc75xx Yu Zhao
2018-10-04 20:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181004.135202.1340830794025516563.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@shawell.net \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox