From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net: dsa: b53: Keep CPU port as tagged in all VLANs Date: Thu, 04 Oct 2018 21:53:06 -0700 (PDT) Message-ID: <20181004.215306.257567278871187581.davem@davemloft.net> References: <20181005032413.8866-1-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, lists@wiesinger.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, linux-kernel@vger.kernel.org To: f.fainelli@gmail.com Return-path: In-Reply-To: <20181005032413.8866-1-f.fainelli@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Florian Fainelli Date: Thu, 4 Oct 2018 20:24:13 -0700 > Commit c499696e7901 ("net: dsa: b53: Stop using dev->cpu_port > incorrectly") was a bit too trigger happy in removing the CPU port from > the VLAN membership because we rely on DSA to program the CPU port VLAN, > which it does, except it does not bother itself with tagged/untagged and > just usese untagged. > > Having the CPU port "follow" the user ports tagged/untagged is not great > and does not allow for properly differentiating, so keep the CPU port > tagged in all VLANs. > > Reported-by: Gerhard Wiesinger > Fixes: c499696e7901 ("net: dsa: b53: Stop using dev->cpu_port incorrectly") > Signed-off-by: Florian Fainelli Applied.