From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bjorn Andersson Subject: Re: [PATCH] soc: qcom: qmi_interface: Limit txn ids to U16_MAX Date: Wed, 3 Oct 2018 21:37:59 -0700 Message-ID: <20181004043759.GB1656@tuxbook-pro> References: <1538545205-17939-1-git-send-email-aneela@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: davem@davemloft.net, clew@codeaurora.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, fw@strlen.de, hannes@stressinduktion.org, dvlasenk@redhat.com, nicolas.dechesne@linaro.org, Andy Gross , David Brown , "open list:ARM/QUALCOMM SUPPORT" To: Arun Kumar Neelakantam Return-path: Content-Disposition: inline In-Reply-To: <1538545205-17939-1-git-send-email-aneela@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Tue 02 Oct 22:40 PDT 2018, Arun Kumar Neelakantam wrote: > Txn IDs created up to INT_MAX cause overflow while storing > the IDs in u16 type supported by QMI header. > > Limit the txn IDs max value to U16_MAX to avoid overflow. > > Signed-off-by: Arun Kumar Neelakantam Reviewed-by: Bjorn Andersson Regards, Bjorn > --- > drivers/soc/qcom/qmi_interface.c | 2 +- > include/linux/soc/qcom/qmi.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/soc/qcom/qmi_interface.c b/drivers/soc/qcom/qmi_interface.c > index 938ca41c..c239a28 100644 > --- a/drivers/soc/qcom/qmi_interface.c > +++ b/drivers/soc/qcom/qmi_interface.c > @@ -318,7 +318,7 @@ int qmi_txn_init(struct qmi_handle *qmi, struct qmi_txn *txn, > txn->dest = c_struct; > > mutex_lock(&qmi->txn_lock); > - ret = idr_alloc_cyclic(&qmi->txns, txn, 0, INT_MAX, GFP_KERNEL); > + ret = idr_alloc_cyclic(&qmi->txns, txn, 0, U16_MAX, GFP_KERNEL); > if (ret < 0) > pr_err("failed to allocate transaction id\n"); > > diff --git a/include/linux/soc/qcom/qmi.h b/include/linux/soc/qcom/qmi.h > index f4de336..5efa2b6 100644 > --- a/include/linux/soc/qcom/qmi.h > +++ b/include/linux/soc/qcom/qmi.h > @@ -166,7 +166,7 @@ struct qmi_ops { > struct qmi_txn { > struct qmi_handle *qmi; > > - int id; > + u16 id; > > struct mutex lock; > struct completion completion; > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >