* [PATCH] atm: nicstar: Replace spin_is_locked() with spin_trylock()
@ 2018-10-04 7:46 Lance Roy
2018-10-05 21:32 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Lance Roy @ 2018-10-04 7:46 UTC (permalink / raw)
To: linux-kernel
Cc: Paul E. McKenney, Lance Roy, Chas Williams, linux-atm-general,
netdev
ns_poll() used spin_is_locked() + spin_lock() to get achieve the same
thing as a spin_trylock(), so simplify it by using that instead. This is
also a step towards possibly removing spin_is_locked().
Signed-off-by: Lance Roy <ldr709@gmail.com>
Cc: Chas Williams <3chas3@gmail.com>
Cc: <linux-atm-general@lists.sourceforge.net>
Cc: <netdev@vger.kernel.org>
---
drivers/atm/nicstar.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/atm/nicstar.c b/drivers/atm/nicstar.c
index cbec9adc01c7..ae4aa02e4dc6 100644
--- a/drivers/atm/nicstar.c
+++ b/drivers/atm/nicstar.c
@@ -2689,11 +2689,10 @@ static void ns_poll(struct timer_list *unused)
PRINTK("nicstar: Entering ns_poll().\n");
for (i = 0; i < num_cards; i++) {
card = cards[i];
- if (spin_is_locked(&card->int_lock)) {
+ if (!spin_trylock_irqsave(&card->int_lock, flags)) {
/* Probably it isn't worth spinning */
continue;
}
- spin_lock_irqsave(&card->int_lock, flags);
stat_w = 0;
stat_r = readl(card->membase + STAT);
--
2.19.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] atm: nicstar: Replace spin_is_locked() with spin_trylock()
2018-10-04 7:46 [PATCH] atm: nicstar: Replace spin_is_locked() with spin_trylock() Lance Roy
@ 2018-10-05 21:32 ` David Miller
2018-10-06 16:59 ` Paul E. McKenney
0 siblings, 1 reply; 3+ messages in thread
From: David Miller @ 2018-10-05 21:32 UTC (permalink / raw)
To: ldr709; +Cc: linux-kernel, paulmck, 3chas3, linux-atm-general, netdev
From: Lance Roy <ldr709@gmail.com>
Date: Thu, 4 Oct 2018 00:46:57 -0700
> ns_poll() used spin_is_locked() + spin_lock() to get achieve the same
> thing as a spin_trylock(), so simplify it by using that instead. This is
> also a step towards possibly removing spin_is_locked().
>
> Signed-off-by: Lance Roy <ldr709@gmail.com>
Applied to net-next.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] atm: nicstar: Replace spin_is_locked() with spin_trylock()
2018-10-05 21:32 ` David Miller
@ 2018-10-06 16:59 ` Paul E. McKenney
0 siblings, 0 replies; 3+ messages in thread
From: Paul E. McKenney @ 2018-10-06 16:59 UTC (permalink / raw)
To: David Miller; +Cc: ldr709, linux-kernel, 3chas3, linux-atm-general, netdev
On Fri, Oct 05, 2018 at 02:32:36PM -0700, David Miller wrote:
> From: Lance Roy <ldr709@gmail.com>
> Date: Thu, 4 Oct 2018 00:46:57 -0700
>
> > ns_poll() used spin_is_locked() + spin_lock() to get achieve the same
> > thing as a spin_trylock(), so simplify it by using that instead. This is
> > also a step towards possibly removing spin_is_locked().
> >
> > Signed-off-by: Lance Roy <ldr709@gmail.com>
>
> Applied to net-next.
Thank you, Dave! I have dropped this one from my tree.
Thanx, Paul
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-06 16:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-04 7:46 [PATCH] atm: nicstar: Replace spin_is_locked() with spin_trylock() Lance Roy
2018-10-05 21:32 ` David Miller
2018-10-06 16:59 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).