From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Chevallier Subject: Re: [PATCH net] net: mvpp2: Extract the correct ethtype from the skb for tx csum offload Date: Thu, 4 Oct 2018 15:13:50 +0200 Message-ID: <20181004151350.11dfb626@bootlin.com> References: <20181004080308.7687-1-maxime.chevallier@bootlin.com> <13fb6bd4-db67-6c35-9e6d-09ed89e10a45@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Antoine Tenart , thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com, miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, ymarkman@marvell.com, mw@semihalf.com To: Sergei Shtylyov Return-path: Received: from mail.bootlin.com ([62.4.15.54]:38489 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727336AbeJDUHR (ORCPT ); Thu, 4 Oct 2018 16:07:17 -0400 In-Reply-To: <13fb6bd4-db67-6c35-9e6d-09ed89e10a45@cogentembedded.com> Sender: netdev-owner@vger.kernel.org List-ID: Hello Sergei, On Thu, 4 Oct 2018 12:50:17 +0300 Sergei Shtylyov wrote: >Hello! > >On 10/4/2018 11:03 AM, Maxime Chevallier wrote: > >> When offloading the L3 and L4 csum computation on TX, we need to extract >> the l3_proto from the ethtype, independently of the presence of a vlan >> tag. >> >> The actual driver uses skb->protocol as-is, resulting in packets with >> the wrong L4 checksum being sent when there's a vlan tag in the packet >> header and checksum offloading is enabled. >> >> This commit makes use of vlan_protocol_get() to get the correct ethtype >> regardless the presence of a vlan tag. > ^ of? > >> Fixes: 3f51850 ("ethernet: Add new driver for Marvell Armada 375 network unit") > > 12 hex digits needed here. Sorry about that, I'll resend with a proper Fixes tag. Thanks, Maxime