From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Subject: Re: [RFC PATCH bpf-next v4 7/7] selftests/bpf: add test cases for queue and stack maps Date: Thu, 4 Oct 2018 16:59:45 -0700 Message-ID: <20181004235943.jjv76cjanu7ncv57@ast-mbp.dhcp.thefacebook.com> References: <153867314370.10087.2202062772042248653.stgit@kernel> <153867318092.10087.8115445755907117246.stgit@kernel> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org To: Mauricio Vasquez B Return-path: Received: from mail-pg1-f193.google.com ([209.85.215.193]:46865 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726038AbeJEGzn (ORCPT ); Fri, 5 Oct 2018 02:55:43 -0400 Received: by mail-pg1-f193.google.com with SMTP id a5-v6so3861229pgv.13 for ; Thu, 04 Oct 2018 16:59:47 -0700 (PDT) Content-Disposition: inline In-Reply-To: <153867318092.10087.8115445755907117246.stgit@kernel> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Oct 04, 2018 at 07:13:00PM +0200, Mauricio Vasquez B wrote: > Two types of tests are done: > - test_maps: only userspace api. > - test_progs: userspace api and ebpf helpers. > > Signed-off-by: Mauricio Vasquez B overall looks very close. thank for you working on it. please fix the nits and resubmit without rfc tag. Thx!