From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] be2net: don't flip hw_features when VXLANs are added/deleted Date: Fri, 05 Oct 2018 00:59:44 -0700 (PDT) Message-ID: <20181005.005944.676060322932993396.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, sriharsha.basavapatna@broadcom.com, ajit.khaparde@broadcom.com, sathya.perla@broadcom.com, sd@queasysnail.net To: dcaratti@redhat.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:35888 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727572AbeJEO5S (ORCPT ); Fri, 5 Oct 2018 10:57:18 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Davide Caratti Date: Wed, 3 Oct 2018 15:20:58 +0200 > the be2net implementation of .ndo_tunnel_{add,del}() changes the value of > NETIF_F_GSO_UDP_TUNNEL bit in 'features' and 'hw_features', but it forgets > to call netdev_features_change(). Moreover, ethtool setting for that bit > can potentially be reverted after a tunnel is added or removed. > > GSO already does software segmentation when 'hw_enc_features' is 0, even > if VXLAN offload is turned on. In addition, commit 096de2f83ebc ("benet: > stricter vxlan offloading check in be_features_check") avoids hardware > segmentation of non-VXLAN tunneled packets, or VXLAN packets having wrong > destination port. So, it's safe to avoid flipping the above feature on > addition/deletion of VXLAN tunnels. > > Fixes: 630f4b70567f ("be2net: Export tunnel offloads only when a VxLAN tunnel is created") > Signed-off-by: Davide Caratti Applied, thank you.