From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v2] net: phy: phylink: fix SFP interface autodetection Date: Fri, 05 Oct 2018 01:05:09 -0700 (PDT) Message-ID: <20181005.010509.468706187273505393.davem@davemloft.net> References: <8b8a01c07bf9b85c09de2d6d6b08068d384e37b8.1538582689.git.baruch@tkos.co.il> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, linux@armlinux.org.uk, antoine.tenart@bootlin.com, gregory.clement@bootlin.com, ori.shemtov@solid-run.com To: baruch@tkos.co.il Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:35988 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727581AbeJEPCo (ORCPT ); Fri, 5 Oct 2018 11:02:44 -0400 In-Reply-To: <8b8a01c07bf9b85c09de2d6d6b08068d384e37b8.1538582689.git.baruch@tkos.co.il> Sender: netdev-owner@vger.kernel.org List-ID: From: Baruch Siach Date: Wed, 3 Oct 2018 19:04:49 +0300 > When connecting SFP PHY to phylink use the detected interface. > Otherwise, the link fails to come up when the configured 'phy-mode' > differs from the SFP detected mode. > > Move most of phylink_connect_phy() into __phylink_connect_phy(), and > leave phylink_connect_phy() as a wrapper. phylink_sfp_connect_phy() can > now pass the SFP detected PHY interface to __phylink_connect_phy(). > > This fixes 1GB SFP module link up on eth3 of the Macchiatobin board that > is configured in the DT to "2500base-x" phy-mode. > > Fixes: 9525ae83959b6 ("phylink: add phylink infrastructure") > Suggested-by: Russell King > Signed-off-by: Baruch Siach > --- > v2: Leave the phylink_connect_phy() functionality unchanged. Only > phylink_sfp_connect_phy() calls __phylink_connect_phy() with the > detected interface (Russell King) Applied and queued up for -stable.