From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 02/19] net: usb: aqc111: Add bind and empty unbind callbacks Date: Fri, 05 Oct 2018 10:39:56 -0700 (PDT) Message-ID: <20181005.103956.929408559960094011.davem@davemloft.net> References: <3f15ced11f712a8e99ac5461dcaec22265503241.1538734658.git.igor.russkikh@aquantia.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, Dmitry.Bezrukov@aquantia.com To: Igor.Russkikh@aquantia.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:43218 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727941AbeJFAjl (ORCPT ); Fri, 5 Oct 2018 20:39:41 -0400 In-Reply-To: <3f15ced11f712a8e99ac5461dcaec22265503241.1538734658.git.igor.russkikh@aquantia.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Igor Russkikh Date: Fri, 5 Oct 2018 10:24:42 +0000 > +static int aqc111_bind(struct usbnet *dev, struct usb_interface *intf) > +{ > + int ret; > + struct usb_device *udev = interface_to_usbdev(intf); Please always order local variable declarations from longest to shortest line (reverse christmas tree).