From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 06/19] net: usb: aqc111: Introduce link management Date: Fri, 05 Oct 2018 10:46:06 -0700 (PDT) Message-ID: <20181005.104606.97635572200071855.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org, Dmitry.Bezrukov@aquantia.com To: Igor.Russkikh@aquantia.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:43346 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728543AbeJFApx (ORCPT ); Fri, 5 Oct 2018 20:45:53 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: From: Igor Russkikh Date: Fri, 5 Oct 2018 10:24:55 +0000 > + switch (aqc111_data->link_speed) { > + case AQ_INT_SPEED_5G: > + { > + link_speed = 5000; > + reg8 = 0x05; > + reg16 = 0x001F; > + break; > + } Please do not put curly braces around switch cases. You aren't declaring local scope variables in these case statements so the curly braces are completely unnecessary and look ugly.