From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net] net: sched: Add policy validation for tc attributes Date: Fri, 05 Oct 2018 14:27:12 -0700 (PDT) Message-ID: <20181005.142712.1319668539769973294.davem@davemloft.net> References: <20181003220536.16123-1-dsahern@kernel.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jiri@mellanox.com, xiyou.wangcong@gmail.com, jhs@mojatatu.com, dsahern@gmail.com To: dsahern@kernel.org Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:46586 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725952AbeJFE1q (ORCPT ); Sat, 6 Oct 2018 00:27:46 -0400 In-Reply-To: <20181003220536.16123-1-dsahern@kernel.org> Sender: netdev-owner@vger.kernel.org List-ID: From: David Ahern Date: Wed, 3 Oct 2018 15:05:36 -0700 > From: David Ahern > > A number of TC attributes are processed without proper validation > (e.g., length checks). Add a tca policy for all input attributes and use > when invoking nlmsg_parse. > > The 2 Fixes tags below cover the latest additions. The other attributes > are a string (KIND), nested attribute (OPTIONS which does seem to have > validation in most cases), for dumps only or a flag. > > Fixes: 5bc1701881e39 ("net: sched: introduce multichain support for filters") > Fixes: d47a6b0e7c492 ("net: sched: introduce ingress/egress block index attributes for qdisc") > Signed-off-by: David Ahern Applied and queued up for -stable, thanks David.