From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next] socket: Tighten no-error check in bind() Date: Fri, 05 Oct 2018 14:35:06 -0700 (PDT) Message-ID: <20181005.143506.1618299417544018523.davem@davemloft.net> References: <20181004090940.4002-1-jakub@cloudflare.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: jakub@cloudflare.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:46718 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725896AbeJFEfl (ORCPT ); Sat, 6 Oct 2018 00:35:41 -0400 In-Reply-To: <20181004090940.4002-1-jakub@cloudflare.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Jakub Sitnicki Date: Thu, 4 Oct 2018 11:09:40 +0200 > move_addr_to_kernel() returns only negative values on error, or zero on > success. Rewrite the error check to an idiomatic form to avoid confusing > the reader. > > Signed-off-by: Jakub Sitnicki Applied.