From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next 00/20] rtnetlink: Add support for rigid checking of data in dump request Date: Fri, 05 Oct 2018 14:58:01 -0700 (PDT) Message-ID: <20181005.145801.2273793268534627951.davem@davemloft.net> References: <20181004213355.14899-1-dsahern@kernel.org> <73fb03a7-ab31-f6a4-d961-bcc42dccf68f@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: dsahern@kernel.org, netdev@vger.kernel.org, christian@brauner.io, jbenc@redhat.com, stephen@networkplumber.org To: dsahern@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:47044 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725787AbeJFE6m (ORCPT ); Sat, 6 Oct 2018 00:58:42 -0400 In-Reply-To: <73fb03a7-ab31-f6a4-d961-bcc42dccf68f@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: David Ahern Date: Fri, 5 Oct 2018 15:18:11 -0600 > One thing I missed in the rfc and v1 versions is strict attribute > parsing -- ie., there should be nothing remaining after nla_parse is > done. I have a new patch that adds an nlmsg_parse_strict and > nla_parse_strict that returns -EINVAL (with extack filled in) if that > happens. The new patch pushes the set over 20. > > I can peel off the first 3 patches from this set which add extack to the > dumps and down to nlmsg_parse and send those separately if preferred. Don't worry about it, just send the whole thing. My rule with patch series sizes is "be reasonable", rather than a strict number requirement. Thanks.