From: Andrew Lunn <andrew@lunn.ch>
To: Pankaj Bansal <pankaj.bansal@nxp.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Alexandru Marginean <alexandru.marginean@nxp.com>
Subject: Re: [PATCH 2/2] netdev/phy: add MDIO bus multiplexer driven by a regmap
Date: Fri, 5 Oct 2018 15:53:17 +0200 [thread overview]
Message-ID: <20181005135317.GA16682@lunn.ch> (raw)
In-Reply-To: <HE1PR0402MB3323DB8B3C52F4C14D3BC46DF1EB0@HE1PR0402MB3323.eurprd04.prod.outlook.com>
> > > + ret = regmap_update_bits_check(s->regmap,
> > > + s->mux_reg,
> > > + s->mask,
> > > + desired_child,
> > > + &change);
> >
> > When getting the mask from DT, you use be32_to_cpup().
> > When testing the reg value against the mask, you use be32_to_cpup().
> > Here you do not use be32_to_cpup()?
>
> Can you please tell me for which variable you mean I should use be32_to_cpup?
> I use be32_to_cpup when reading device tree entries.
> After being read, their values are stored in structure. After that no need to do be32_to_cpup
desired_child is read from DT by the mdio-mux core.
I'm just wondering why any of this be32_to_cpup() is needed. Why not
just use of_property_read_u32()?
Andrew
next prev parent reply other threads:[~2018-10-05 20:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20181005082926.27845-1-pankaj.bansal@nxp.com>
[not found] ` <20181005082926.27845-3-pankaj.bansal@nxp.com>
[not found] ` <20181005035142.GC7715@lunn.ch>
2018-10-05 4:31 ` [PATCH 2/2] netdev/phy: add MDIO bus multiplexer driven by a regmap Pankaj Bansal
2018-10-05 13:53 ` Andrew Lunn [this message]
[not found] ` <20181005082926.27845-2-pankaj.bansal@nxp.com>
[not found] ` <20181005030818.GB7715@lunn.ch>
2018-10-05 4:32 ` [PATCH 1/2] dt-bindings: net: add MDIO bus multiplexer driven by a regmap device Pankaj Bansal
2018-10-07 18:24 ` [PATCH v2 0/2] " Pankaj Bansal
2018-10-07 18:24 ` [PATCH v2 1/2] dt-bindings: net: " Pankaj Bansal
2018-10-07 18:01 ` Florian Fainelli
2018-10-18 4:30 ` Pankaj Bansal
2018-10-22 4:22 ` Pankaj Bansal
2018-10-22 17:08 ` Florian Fainelli
2018-10-07 18:24 ` [PATCH v2 2/2] netdev/phy: add MDIO bus multiplexer driven by a regmap Pankaj Bansal
2018-10-07 18:08 ` Florian Fainelli
2018-10-18 4:35 ` Pankaj Bansal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181005135317.GA16682@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandru.marginean@nxp.com \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pankaj.bansal@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).