From: Marek Behun <marek.behun@nic.cz>
To: Andrew Lunn <andrew@lunn.ch>
Cc: netdev <netdev@vger.kernel.org>,
Florian Fainelli <f.fainelli@gmail.com>,
"David S . Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next] net: dsa: mc88e6xxx: Fix 88E6141/6341 2500mbps SERDES speed
Date: Sat, 6 Oct 2018 02:38:10 +0200 [thread overview]
Message-ID: <20181006023810.20be216e@nic.cz> (raw)
In-Reply-To: <20181005212055.GA28680@lunn.ch>
> Hi Marek
>
> I'm confused.
>
> The alt bit is used for configuring 2500. You say 2500 is only
> supported on port 5. But !port is only true for port 0?
>
> Andrew
On Topaz alt_bit is used only for port 0 for differentiating 100 mbps
vs 200 mbps. The choices for SpdValue are 0 for 10 mbps, 1 for 100
mbps or 200 mbps (if alt_bit), 2 for 1000 mbps and 3 for 2500 mbps.
2500 is allowed only on port 5. alt_bit is not used on Topaz for port
5 (serdes), therefore I used !port.
Marek
next prev parent reply other threads:[~2018-10-06 7:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 14:42 [PATCH net-next] net: dsa: mc88e6xxx: Fix 88E6141/6341 2500mbps SERDES speed Marek Behún
2018-10-05 21:20 ` Andrew Lunn
2018-10-06 0:38 ` Marek Behun [this message]
2018-10-06 18:37 ` Andrew Lunn
2018-10-06 22:00 ` Marek Behun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181006023810.20be216e@nic.cz \
--to=marek.behun@nic.cz \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).