From: David Miller <davem@davemloft.net>
To: jikos@kernel.org
Cc: yoshfuji@linux-ipv6.org, pabeni@redhat.com, edumazet@google.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] udp: Unbreak modules that rely on external __skb_recv_udp() availability
Date: Sun, 07 Oct 2018 20:34:21 -0700 (PDT) [thread overview]
Message-ID: <20181007.203421.1496534902899406968.davem@davemloft.net> (raw)
In-Reply-To: <nycvar.YFH.7.76.1810041335180.14430@cbobk.fhfr.pm>
From: Jiri Kosina <jikos@kernel.org>
Date: Thu, 4 Oct 2018 13:37:32 +0200 (CEST)
> From: Jiri Kosina <jkosina@suse.cz>
>
> Commit 2276f58ac589 ("udp: use a separate rx queue for packet reception")
> turned static inline __skb_recv_udp() from being a trivial helper around
> __skb_recv_datagram() into a UDP specific implementaion, making it
> EXPORT_SYMBOL_GPL() at the same time.
>
> There are external modules that got broken by __skb_recv_udp() not being
> visible to them. Let's unbreak them by making __skb_recv_udp EXPORT_SYMBOL().
>
> Rationale (one of those) why this is actually "technically correct" thing
> to do: __skb_recv_udp() used to be an inline wrapper around
> __skb_recv_datagram(), which itself (still, and correctly so, I believe)
> is EXPORT_SYMBOL().
>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: Eric Dumazet <edumazet@google.com>
> Fixes: 2276f58ac589 ("udp: use a separate rx queue for packet reception")
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Applied...
But waiting from 4.13 until now to bring this up is really pushing it...
next prev parent reply other threads:[~2018-10-08 3:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 11:37 [PATCH] udp: Unbreak modules that rely on external __skb_recv_udp() availability Jiri Kosina
2018-10-08 3:34 ` David Miller [this message]
2018-10-08 5:15 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181007.203421.1496534902899406968.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).