From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] udp: Unbreak modules that rely on external __skb_recv_udp() availability Date: Sun, 07 Oct 2018 20:34:21 -0700 (PDT) Message-ID: <20181007.203421.1496534902899406968.davem@davemloft.net> References: Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: yoshfuji@linux-ipv6.org, pabeni@redhat.com, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: jikos@kernel.org Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Jiri Kosina Date: Thu, 4 Oct 2018 13:37:32 +0200 (CEST) > From: Jiri Kosina > > Commit 2276f58ac589 ("udp: use a separate rx queue for packet reception") > turned static inline __skb_recv_udp() from being a trivial helper around > __skb_recv_datagram() into a UDP specific implementaion, making it > EXPORT_SYMBOL_GPL() at the same time. > > There are external modules that got broken by __skb_recv_udp() not being > visible to them. Let's unbreak them by making __skb_recv_udp EXPORT_SYMBOL(). > > Rationale (one of those) why this is actually "technically correct" thing > to do: __skb_recv_udp() used to be an inline wrapper around > __skb_recv_datagram(), which itself (still, and correctly so, I believe) > is EXPORT_SYMBOL(). > > Cc: Paolo Abeni > Cc: Eric Dumazet > Fixes: 2276f58ac589 ("udp: use a separate rx queue for packet reception") > Signed-off-by: Jiri Kosina Applied... But waiting from 4.13 until now to bring this up is really pushing it...