From: David Miller <davem@davemloft.net>
To: sunil.kovvuri@gmail.com
Cc: netdev@vger.kernel.org, arnd@arndb.de, linux-soc@vger.kernel.org,
sgoutham@marvell.com
Subject: Re: [PATCH v8 05/15] octeontx2-af: Add mailbox IRQ and msg handlers
Date: Sun, 07 Oct 2018 21:11:46 -0700 (PDT) [thread overview]
Message-ID: <20181007.211146.1803805129203289271.davem@davemloft.net> (raw)
In-Reply-To: <1538924364-18781-6-git-send-email-sunil.kovvuri@gmail.com>
From: sunil.kovvuri@gmail.com
Date: Sun, 7 Oct 2018 20:29:14 +0530
> + req_hdr = (struct mbox_hdr *)(mdev->mbase + mbox->rx_start);
I commented in the previous patch series version, for patch #4, that
such casts are unnecessary and should be removed.
You are in for a very long review process if you only consider feedback
given to you for the specific patch for which it is given, rather than
your entire series.
Please put forth the effort to fix the problems pointed out to you in
your entire series.
Thank you.
next prev parent reply other threads:[~2018-10-08 11:21 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-07 14:59 [PATCH v8 00/15] octeontx2-af: Add RVU Admin Function driver sunil.kovvuri
2018-10-07 14:59 ` [PATCH v8 01/15] octeontx2-af: Add Marvell OcteonTX2 RVU AF driver sunil.kovvuri
2018-10-08 12:22 ` Arnd Bergmann
2018-10-08 13:50 ` Sunil Kovvuri
2018-10-08 14:29 ` Arnd Bergmann
2018-10-07 14:59 ` [PATCH v8 02/15] octeontx2-af: Reset all RVU blocks sunil.kovvuri
2018-10-08 12:16 ` Arnd Bergmann
2018-10-09 7:10 ` Sunil Kovvuri
2018-10-07 14:59 ` [PATCH v8 03/15] octeontx2-af: Gather RVU blocks HW info sunil.kovvuri
2018-10-07 14:59 ` [PATCH v8 04/15] octeontx2-af: Add mailbox support infra sunil.kovvuri
2018-10-07 14:59 ` [PATCH v8 05/15] octeontx2-af: Add mailbox IRQ and msg handlers sunil.kovvuri
2018-10-08 4:11 ` David Miller [this message]
2018-10-07 14:59 ` [PATCH v8 06/15] octeontx2-af: Convert mbox msg id check to a macro sunil.kovvuri
2018-10-07 14:59 ` [PATCH v8 07/15] octeontx2-af: Scan blocks for LFs provisioned to PF/VF sunil.kovvuri
2018-10-07 14:59 ` [PATCH v8 08/15] octeontx2-af: Add RVU block LF provisioning support sunil.kovvuri
2018-10-08 12:11 ` Arnd Bergmann
2018-10-08 13:59 ` Sunil Kovvuri
2018-10-08 14:29 ` Arnd Bergmann
2018-10-07 14:59 ` [PATCH v8 09/15] octeontx2-af: Configure block LF's MSIX vector offset sunil.kovvuri
2018-10-07 14:59 ` [PATCH v8 10/15] octeontx2-af: Reconfig MSIX base with IOVA sunil.kovvuri
2018-10-08 12:08 ` Arnd Bergmann
2018-10-09 7:02 ` Sunil Kovvuri
2018-10-09 7:57 ` Arnd Bergmann
2018-10-09 9:20 ` Sunil Kovvuri
2018-10-09 12:00 ` Arnd Bergmann
2018-10-10 7:35 ` Sunil Kovvuri
2018-10-10 7:58 ` Arnd Bergmann
2018-10-07 14:59 ` [PATCH v8 11/15] octeontx2-af: Add Marvell OcteonTX2 CGX driver sunil.kovvuri
2018-10-07 14:59 ` [PATCH v8 12/15] octeontx2-af: Set RVU PFs to CGX LMACs mapping sunil.kovvuri
2018-10-07 14:59 ` [PATCH v8 13/15] octeontx2-af: Add support for CGX link management sunil.kovvuri
2018-10-07 14:59 ` [PATCH v8 14/15] octeontx2-af: Register for CGX lmac events sunil.kovvuri
2018-10-07 14:59 ` [PATCH v8 15/15] MAINTAINERS: Add entry for Marvell OcteonTX2 Admin Function driver sunil.kovvuri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181007.211146.1803805129203289271.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=linux-soc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sgoutham@marvell.com \
--cc=sunil.kovvuri@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).