From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH v8 05/15] octeontx2-af: Add mailbox IRQ and msg handlers Date: Sun, 07 Oct 2018 21:11:46 -0700 (PDT) Message-ID: <20181007.211146.1803805129203289271.davem@davemloft.net> References: <1538924364-18781-1-git-send-email-sunil.kovvuri@gmail.com> <1538924364-18781-6-git-send-email-sunil.kovvuri@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, arnd@arndb.de, linux-soc@vger.kernel.org, sgoutham@marvell.com To: sunil.kovvuri@gmail.com Return-path: Received: from shards.monkeyblade.net ([23.128.96.9]:47414 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725760AbeJHLV1 (ORCPT ); Mon, 8 Oct 2018 07:21:27 -0400 In-Reply-To: <1538924364-18781-6-git-send-email-sunil.kovvuri@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: sunil.kovvuri@gmail.com Date: Sun, 7 Oct 2018 20:29:14 +0530 > + req_hdr = (struct mbox_hdr *)(mdev->mbase + mbox->rx_start); I commented in the previous patch series version, for patch #4, that such casts are unnecessary and should be removed. You are in for a very long review process if you only consider feedback given to you for the specific patch for which it is given, rather than your entire series. Please put forth the effort to fix the problems pointed out to you in your entire series. Thank you.