From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Cochran Subject: Re: [PATCH V2 net-next 2/5] net: Introduce a new MII time stamping interface. Date: Sun, 7 Oct 2018 14:07:28 -0700 Message-ID: <20181007210728.nimnrijadb2skedg@localhost> References: <20181007173823.21590-3-richardcochran@gmail.com> <20181007182751.GC22794@lunn.ch> <20181007191551.gy4l4g6qdgz6ztez@localhost> <20181007195400.GA25883@lunn.ch> <20181007205906.3h7fpyxdhc24o6lc@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, David Miller , Florian Fainelli , Jacob Keller , Mark Rutland , Miroslav Lichvar , Rob Herring , Willem de Bruijn To: Andrew Lunn Return-path: Received: from mail-pf1-f193.google.com ([209.85.210.193]:41643 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725755AbeJHEQD (ORCPT ); Mon, 8 Oct 2018 00:16:03 -0400 Content-Disposition: inline In-Reply-To: <20181007205906.3h7fpyxdhc24o6lc@localhost> Sender: netdev-owner@vger.kernel.org List-ID: On Sun, Oct 07, 2018 at 01:59:06PM -0700, Richard Cochran wrote: > On Sun, Oct 07, 2018 at 09:54:00PM +0200, Andrew Lunn wrote: > > 1) phylink, not phdev. We have been pushing some MAC drivers towards > > phylink, especially those which support >1Gbp. > > If a phylink device appears that wants time stamping, can't we add the > call to register_mii_timestamper()? Actually, I see that 'struct phylink' has a 'struct phy_device *phydev', and so it can implement the 'struct mii_timestamper' interface directly. Thanks, Richard